Hi Niall,
As others have mentioned there are several files with copyright date issues.
Running "hg nits" will catch those.
Section 4 - other than the copyright stuff everything looks fine.
It looks like most of this has been covered pretty well are there any areas you
still need someone to look at?
Thanks,
-evan
On 4/21/11 5:28 PM, Evan Layton wrote:
Hi Niall,
We had talked about me looking at group 2 but Drew covered that pretty
well. I didn't see anything Drew didn't already cover so I'll move to
group 4 and if I get time group 3.
-evan
On 4/20/11 7:51 PM, Niall Power wrote:
Hi all,
I'm looking for a few brave souls to review my implementation of a boot
checkpoint based on pybootmgmgt. If you'd like to volunteer but get around to
it later, please let me know when
you could be available to review.
The changes aren't huge mostly tweaks here and there, with the bulk of the
code contained in
usr/src/lib/install_boot/boot.py (about 1100 LOC) and boot_spec.py (about 250
LOC) so I'd be
very grateful for any comments received by April 27/28th. I'll even buy you a
pint :-)
The changes can be logically grouped together as follows if you want to look
at a subset of the changes:
1) Boot schema definitions and Data Object Cache support
usr/src/lib/install_manifest/dtd/Makefile
usr/src/lib/install_manifest/dtd/boot.dtd
usr/src/lib/install_manifest/dtd/dc.dtd
usr/src/lib/install_boot/boot_spec.py
usr/src/lib/install_boot/test/test_boot_spec.py (Tests)
2) Boot checkpoint implementation
usr/src/lib/install_boot/__init__.py
usr/src/lib/install_boot/boot.py
usr/src/lib/install_boot/test/test_boot.py (Tests)
3) Distro Constructor changes to use new boot-setup checkpoint instead of
grub-setup for X86
usr/src/cmd/distro_const/__init__.py
usr/src/cmd/distro_const/checkpoints/create_iso.py
usr/src/cmd/distro_const/manifest/dc_ai_x86.xml
usr/src/cmd/distro_const/manifest/dc_livecd.xml
usr/src/cmd/distro_const/manifest/dc_text_x86.xml
4) Packaging and makefile changes to slim_source repo
usr/src/Makefile.master
usr/src/Targetdirs
usr/src/lib/Makefile
usr/src/lib/Makefile.targ
usr/src/lib/install_boot/Makefile
usr/src/lib/install_manifest/dtd/Makefile
usr/src/pkg/manifests/system-library-install.mf
Webrev location:
http://cr.opensolaris.org/~niall/cud-boot/
Thanks,
Niall
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
