On 05/ 2/11 05:58 AM, Niall Power wrote: ...
auto_install.py --------------- 165& 169: Should the TI acronomym be substituted with "target instantiation"?Consistency nits: Some user messages end with periods while others don't... With: 173, 193, 205, 209, 214, Without: 158, 161, 165, 169, 177, 201 271: Nit Remove space character betewen "order" and ":"... print "Checkpoints will be run in following order :" -> print "Checkpoints will be run in following order:" 343: Inconsistent docstring formatting (''' -> """) '''If BE exists, then transfer Log Files to New BE''' -> """ If BE exists, then transfer Log Files to New BE """ 420-421: Nit Make double blank lines single for PEP8 compliance 437, 452: See 271 465: Question: if http_proxy is unreachable is it fatal in every case and would it be useful/timesaving to attempt to see if http_proxy is reachable and bail out at this early point of execution before going through the destructive processes of target instantiation etc.?
In general, we should refrain from such checks. Networks are not reliable, as it's easily possible to have intermittent failures in DNS lookups, routers dropping out, proxies being offline, etc. The best thing to do is to not try to over-validate, but assume it's correct and let the networking stack do its job. If it's really wrong, it'll fail eventually.
Dave _______________________________________________ caiman-discuss mailing list [email protected] http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
