Hi Darren.
No further comments on issues removed from this email. Some comments
below...
1011, 1012: What does 524288 represent? Please add a comment.
As I said to Dave, I honestly don't know - this is something we got from the
logger tests.
Well, OK I guess...
FWIW, I did a little investigation and 524288 is 2**19. So looks like
the max size of data sockets can receive must fit into 20 bits, based on
looking at the code.
manifest-locator:
-----------------
Continuing with common definitions implementation, if /var/run/ai.xml is defined
in in install_common like this:
AI_XML="/var/run/ai.xml"
you could replace in manifest-locator
AI_MANIFEST=/var/run/ai.xml
with
AI_MANIFEST=`python -c "import solaris_install.install_common; print
AI_XML"`
66: similarly for AI_SERVICE_LIST
Other defs too?
I think this is another good idea, but we've only minimally changed these, so
I think it would be best done as part of an overall sweep of things.
I could do it, if there were suggestions on where to put such values so that
we could pick them up in scripts.
We could start a file of common definitions, perhaps in the
install_common area. Or we could add defs to install_common/__init__.py.
Then I would suggest making a global Makefile definition that translates
into "python -c import solaris_install.install_common ; print $VAR".
Not sure about the scope of this though... We could do this on a
project-by-project basis and you could be the first one :) The
alternative would be someone to kick this off by going through the whole
gate looking for eligible definitions, but it would seem best for people
to do this for the defs they are most familiar with.
So, if everyone agrees on this, then the issue becomes "who starts doing
this first?" Someone has to start a precedent and others will follow,
kind of like using our Popen instead of subprocess.Popen.
We probably should discuss this as a team...
Thanks,
Jack
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
