cpio.py:

Any reason to not just make the line "else:"?

The rest seems fine.

- Keith

On 05/ 5/11 12:29 PM, Drew Fisher wrote:
Good afternoon!

Could I please get a review of the following CRs:

7042314 <http://monaco.us.oracle.com/detail.jsf?cr=7042314> solaris_install.target.be.be_list() should get information about which is the active BE 7042322 <http://monaco.us.oracle.com/detail.jsf?cr=7042322> CPIOTransfer checkpoint is not removing symlinks

http://cr.opensolaris.org/~drewfish/cr_7042314/

In addition to the changes made for the CRs, I also cleaned up a few pylint errors in cpio.py. All unittests execute cleanly and all files are pep8 clean.

For the changes to be.py, I am planning on turning this code into a more robust Object "in the future" the same way the NVList() and NVPair() classes work. I don't want to start that work at this time due to all the projects that are about to complete.


Thanks!

-Drew


_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss

_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss

Reply via email to