On 5/5/11 1:40 PM, Keith Mitchell wrote:
cpio.py:

Any reason to not just make the line "else:"?

I don't see one.  I also streamlined the code a bit:

                if not self.dry_run:
                    for item in trans.get(CONTENTS):
                        entry = os.path.join(self.dst, item.rstrip())
                        try:
                            if os.path.isdir(item):
                                shutil.rmtree(entry)
                            else:
                                os.unlink(entry)
                        except OSError:
                            # If the item isn't there that's what we
                            # wanted anyway so just continue.
                            pass


How's that look?


The rest seems fine.

Thanks for looking, Keith.

-Drew
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss

Reply via email to