Hi everyone,
Thank you to those that took time to review the changes for converting the Text Installer to the CUD infrastructure. I have incorporated all your comments. Please review the updated webrev. The major changes made as a result of the code review comments and other testing are: * Remove the use of threading in doing target discovery and the actual install. The threading feature in the install engine is used instead. * Remove all code in the text installer that deals with calculating the minimum install size, recommended install size, swap size and dump size. Functions from the target controller is called for getting all the values. * Fix all pep8 errors, and fix all pylint errors that make sense. * Improve the parsing of progress messages to deal with receiving more than 1 message record in a "recv" call. Updated webrev: http://cr.opensolaris.org/~ktung/cud_text_round2/ Diff from the previous webrev is below. There are a lot of files in the list here that I didn't change. Those are changes made by the other projects. http://cr.opensolaris.org/~ktung/cud_text_round1_diff/ Please provide your comments by COB next Tuesday, 5/10/2011, or sooner. Thanks, --Karen _______________________________________________ caiman-discuss mailing list [email protected] http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
