Hi Keith,
Thank you for looking over the updated changes. Please
see my responses inline.
On 05/ 9/11 01:27 PM, Keith Mitchell wrote:
On 05/ 8/11 01:23 AM, Karen Tung wrote:
Hi everyone,
Thank you to those that took time to review the changes
for converting the Text Installer to the CUD infrastructure.
I have incorporated all your comments. Please review
the updated webrev.
The major changes made as a result of the code review
comments and other testing are:
* Remove the use of threading in doing target discovery
and the actual install. The threading feature in the install engine
is used instead.
Hi Karen,
Just a few questions here:
disk_selection:
229: Can you catch a specific exception here?
There are quiet a few things that can cause exceptions, but
I don't really care what the exact problem is. For example, if we are
just running from the local system debugging the UI code, the .image_info
file might not exists and we won't have information about whether we are
net booting
or media booting. Other problem might be
.image_info file doesn't contain the IMAGE_SIZE line or it has the wrong
format..etc..
I can catch the specific exceptions, but since we have a default image
size that people
can use, I don't really feel it is necessary to specify the exceptions.
245: I'm fuzzy on which thread this code runs from, but I don't think
it's the main/UI thread - I think 240-246 needs to be at the end of
wait_for_disks()
Yes, you are right. Moved.
install_progress:
86: I don't think this line should be needed - if it is, we should
talk about how to change terminalui to properly handle what's desired
here.
Yes, this is not needed. I added the validate_loop() function like you
suggested,
and it works very well.
Thanks again for reviewing.
--Karen
- Keith
* Remove all code in the text installer that deals with calculating
the minimum install size, recommended install size, swap size
and dump size. Functions from the target controller is called
for getting all the values.
* Fix all pep8 errors, and fix all pylint errors that make sense.
* Improve the parsing of progress messages to deal with
receiving more than 1 message record in a "recv" call.
Updated webrev:
http://cr.opensolaris.org/~ktung/cud_text_round2/
Diff from the previous webrev is below. There are a lot
of files in the list here that I didn't change. Those are
changes made by the other projects.
http://cr.opensolaris.org/~ktung/cud_text_round1_diff/
Please provide your comments by COB next Tuesday, 5/10/2011,
or sooner.
Thanks,
--Karen
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
