On 05/ 6/11 06:14 PM, Keith Mitchell wrote:
On 05/ 6/11 03:49 AM, Jan Damborsky wrote:
On 05/ 5/11 09:11 AM, Jan Damborsky wrote:
On 05/ 3/11 11:35 PM, Keith Mitchell wrote:
[...]
network_info.py:
98-113: Please use solaris_install.Popen and condense this to
something like:
try:
dladm_popen = Popen(argslist, stdout=Popen.STORE,
stderr=Popen.STORE, logger=LOGGER())
except CalledProcessError as error:
LOGGER().warn("Error occurred during call to dladm: %s", error)
allowed_ips = dladm_popen.stdout.strip()
I will do that.
Hi Keith,
I am now in process of incorporating code review comments and I ran into
issues when trying to use solaris_install.Popen as you proposed above.
In particular, sysconfig fails with following traceback:
You'd think I'd know my own code better!
That should have been:
Popen.check_call(...)
That helped :-)
Sorry!
No problem, Keith :-)
Thank you!
Jan
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
