Re: [caiman-discuss] CR request for 'zone aware interactive configuration scenario'

Tue, 10 May 2011 11:39:29 -0700 

LGTM

On 05/10/11 01:12 AM, Jan Damborsky wrote:

 Hi Keith,
I have incorporated all your comments modulo refactoring system-config/__init__.py 
(I filed 7043403 to track this as a separate issue).

updated full webrev:
http://cr.opensolaris.org/~dambi/cr-7032012-cr/

incremental webrev:
http://cr.opensolaris.org/~dambi/cr-7032012-cr-diff/

Jan


On 05/ 6/11 06:14 PM, Keith Mitchell wrote:

On 05/ 6/11 03:49 AM, Jan Damborsky wrote:

 On 05/ 5/11 09:11 AM, Jan Damborsky wrote:


On 05/ 3/11 11:35 PM, Keith Mitchell wrote:


[...]






network_info.py:
98-113: Please use solaris_install.Popen and condense this to something like: 

try:
dladm_popen = Popen(argslist, stdout=Popen.STORE, stderr=Popen.STORE, logger=LOGGER()) 
except CalledProcessError as error:
    LOGGER().warn("Error occurred during call to dladm: %s", error)
allowed_ips = dladm_popen.stdout.strip()


I will do that.



Hi Keith,
I am now in process of incorporating code review comments and I ran into 
issues when trying to use solaris_install.Popen as you proposed above.
In particular, sysconfig fails with following traceback:


You'd think I'd know my own code better!

That should have been:

Popen.check_call(...)

Sorry!

- Keith



# /usr/sbin/sysconfig create-profile
An unhandled exception occurred.
TypeError: "__init__() got an unexpected keyword argument 'logger'" 
Full traceback data is in the log
Exiting System Configuration Tool. Log is available at:
/var/tmp/install/sysconfig.log
# cat /var/tmp/install/sysconfig.log
2011-05-06 14:13:45,676 InstallationLogger ERROR An unhandled exception occurred. 
Traceback (most recent call last):
File "/usr/lib/python2.6/vendor-packages/solaris_install/sysconfig/__init__.py", line 264, in do_create_profile 
    _show_screens(options)
File "/usr/lib/python2.6/vendor-packages/solaris_install/sysconfig/__init__.py", line 385, in _show_screens 
    win_list = _make_screen_list(main_win)
File "/usr/lib/python2.6/vendor-packages/solaris_install/sysconfig/__init__.py", line 357, in _make_screen_list 
    screens.extend(get_screens_from_groups(main_win))
File "/usr/lib/python2.6/vendor-packages/solaris_install/sysconfig/__init__.py", line 190, in get_screens_from_groups 
    configure_group(SC_GROUP_NETWORK)))
File "/usr/lib/python2.6/vendor-packages/solaris_install/sysconfig/network_type.py", line 94, in __init__ 
    self.ether_nics = NetworkInfo.find_links()
File "/usr/lib/python2.6/vendor-packages/solaris_install/sysconfig/profile/network_info.py", line 77, in find_links 
    stderr=Popen.STORE, logger=LOGGER())
TypeError: __init__() got an unexpected keyword argument 'logger'
2011-05-06 14:13:45,677 InstallationLogger ERROR Sysconfig profile: -> [sysconfig] (<solaris_install.sysconfig.profile.ConfigProfile object at 0x859960c>) 
2011-05-06 14:13:45,678   InstallationLogger INFO       **** END ****
#
From this it seems that solaris_install.Popen() does not recognize 'logger' parameter. But even if I remove logger argument, I am still seeing traceback - now different one: 

# /usr/sbin/sysconfig create-profile
An unhandled exception occurred.
        AttributeError: "'object' object has no attribute 'fileno'"
Full traceback data is in the log
Exiting System Configuration Tool. Log is available at:
/var/tmp/install/sysconfig.log
# cat /var/tmp/install/sysconfig.log
2011-05-06 14:15:32,297 InstallationLogger ERROR An unhandled exception occurred. 
Traceback (most recent call last):
File "/usr/lib/python2.6/vendor-packages/solaris_install/sysconfig/__init__.py", line 264, in do_create_profile 
    _show_screens(options)
File "/usr/lib/python2.6/vendor-packages/solaris_install/sysconfig/__init__.py", line 385, in _show_screens 
    win_list = _make_screen_list(main_win)
File "/usr/lib/python2.6/vendor-packages/solaris_install/sysconfig/__init__.py", line 357, in _make_screen_list 
    screens.extend(get_screens_from_groups(main_win))
File "/usr/lib/python2.6/vendor-packages/solaris_install/sysconfig/__init__.py", line 190, in get_screens_from_groups 
    configure_group(SC_GROUP_NETWORK)))
File "/usr/lib/python2.6/vendor-packages/solaris_install/sysconfig/network_type.py", line 94, in __init__ 
    self.ether_nics = NetworkInfo.find_links()
File "/usr/lib/python2.6/vendor-packages/solaris_install/sysconfig/profile/network_info.py", line 77, in find_links 
    stderr=Popen.STORE)
File "/usr/lib/python2.6/vendor-packages/solaris_install/__init__.py", line 210, in __init__ 
    creationflags=creationflags)
  File "/usr/lib/python2.6/subprocess.py", line 614, in __init__
    errread, errwrite) = self._get_handles(stdin, stdout, stderr)
  File "/usr/lib/python2.6/subprocess.py", line 971, in _get_handles
    c2pwrite = stdout.fileno()
AttributeError: 'object' object has no attribute 'fileno'
2011-05-06 14:15:32,299 InstallationLogger ERROR Sysconfig profile: -> [sysconfig] (<solaris_install.sysconfig.profile.ConfigProfile object at 0x8593d8c>) 
2011-05-06 14:15:32,300   InstallationLogger INFO       **** END ****
#

Could you please help me understand what I am doing wrong ?
Here is incremental webrev with code review comments I have incorporated so far: 
http://cr.opensolaris.org/~dambi/cr-7032012-cr-diff/

Thank you,
Jan







_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss

Reply via email to