Jack and William: Thanks for fixing this and this looks good to me.
----- Original Message ----- From: [email protected] To: [email protected] Cc: [email protected] Sent: Monday, May 9, 2011 12:01:16 PM GMT -08:00 Tijuana / Baja California Subject: Re: [caiman-discuss] Requesting code review: 7040960 Missing usr/src/cmd/ai-webserver/export_profile.py in slim_source cause slim unit test failure. Hi William. Looks pretty good. A few comments / questions: common_profile.py: Please add a comment in Args in validate_profile_string() header that image_dir=None signifies a testing-only condition. validate_profile.py: Just curious: how come image_dir arg in validate_file needs to be set to a default of None? The rest looks good to me. Thanks, Jack On 05/ 9/11 04:44 AM, William Schumann wrote: > http://cr.opensolaris.org/~wmsch/bug-7040960/ > > Mostly path fixes, added path to PYTHONPATH search list for tests in > CGI directory, some small fixes to tests. > > Thanks, > William > _______________________________________________ > caiman-discuss mailing list > [email protected] > http://mail.opensolaris.org/mailman/listinfo/caiman-discuss _______________________________________________ caiman-discuss mailing list [email protected] http://mail.opensolaris.org/mailman/listinfo/caiman-discuss _______________________________________________ caiman-discuss mailing list [email protected] http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
