Hi William.
On 05/10/11 01:56 AM, William Schumann wrote:
Jack,
On 05/ 9/11 09:00 PM, Jack Schwartz wrote:
validate_profile.py:
Just curious: how come image_dir arg in validate_file needs to be set
to a default of None?
Since the purpose of this routine is to validate a profile against a
service_bundle DTD in a particular AI image, the code normally
references a service_bundle in a particular path. During unit
testing, there is no image and no external DTD, so the test validates
against the DTD on the build machine. So, image_dir should never be
None under normal circumstances.
I understand. I asked because all validate_file() did with image_dir
was pass it on to validate_profile_string() which also defaulted
image_dir to None in the code review. From that perspective, setting
the default value in validate_file() was redundant. Looks like you
removed that defaulting in validate_profile_string() before pushing.
Thanks,
Jack
Thanks for the review,
William
The rest looks good to me.
Thanks,
Jack
On 05/ 9/11 04:44 AM, William Schumann wrote:
http://cr.opensolaris.org/~wmsch/bug-7040960/
Mostly path fixes, added path to PYTHONPATH search list for tests in
CGI directory, some small fixes to tests.
Thanks,
William
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
