On 05/17/11 11:45 AM, William Schumann wrote:
On 05/17/11 08:16 PM, Keith Mitchell wrote:
On 05/17/11 11:12 AM, William Schumann wrote:
Keith,
I have one preliminary question:
On 05/16/11 07:29 PM, Keith Mitchell wrote:
...
ns_info.py:
...
225: This dict should be statically defined.
265-276: Statically define this somewhere.
What you mean by 'statically', and why?
I guess "global" would be more precise. Or rather, at the module level.
As written, every time the function is called, the dictionary is
reconstructed;
OK, but they are only called once.
and since the objects seemed to be only read-from, never written-to,
it seemed like they should be defined at the module level, instead of
as locals.
I don't understand why RW vs. RO. should make a difference.
I 'localized' them since their usage was completely local to the
function. This way, the maintainer doesn't have to search for the dicts.
I won't bikeshed over this; I feel they should be defined at the global
level, but the final decision is yours.
Thanks,
William
- Keith
Thanks,
William
...
On 05/ 5/11 08:32 AM, William Schumann wrote:
Requesting code review for adding Name Services to SCI Tool
http://cr.opensolaris.org/~wmsch/bug-7031613/
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
