On 05/12/11 04:33 AM, William Schumann wrote:
Reinstating request for code review for adding Name Services to SCI Tool
http://cr.opensolaris.org/~wmsch/bug-7031613/
Due to the near completion of PSARC/2011/044 Move Name Service Configuration to
SMF (RFE 6959149)
SCI Tool can soon support prompting the user for configuration of name
services. Options are DNS, LDAP, NIS or none.
DNS server and domain were moved - domain has its own screen shared by all name
services, DNS server has its own screen prompting for a list of DNS servers.
Most new code involves the UI.
Thank you for your consideration,
William
Hi William,
Not sure there's much left to cover after Keith's review, but here are a few
minor things I found.
network_nic_configure.py
53 Remove the no longer needed comma after "entries".
ns.py.html
22 New file, shouldn't have a copyright range with 2010
106-7 It seems redundant to say "if the name service is not listed or the system
will use a different name service". Maybe pick one or the other?
124 needs a space after DNS so you don't get DNSquery
132 address for the -> address of the
142 For consistency with other self.intro's, just have backslash here and '_('
on next line
163-4 Here there is a description/example of IP address but at 118 which also
asks for IP address, there isn't.
ns_info.py
26 comment at top of file was copied from another file and doesn't match this
one
120 Use ilist.append(val)
225 Define static dict propdict somewhere else
summary.py
161,162,164,166, and others Should the text being output have spaces in front of
it, ala 157 and 159?
Sue
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
