Darren, a few follow-ups below:
On 05/18/11 06:46 PM, Darren Kenny wrote:
Hi,
I think it's about time I got out another version of the code review for the CUD
AI project.
I've uploaded the webrev at:
http://cr.opensolaris.org/~dkenny/cud_ai-to-slim-2/
And for anyone that's reviewed the code before, there is a diff:
http://cr.opensolaris.org/~dkenny/cud_ai-to-slim-2-diffs/
auto_install.py, 394: You added this comment in response to my review;
as I realize time is short here I'd suggest we leave this as-is and file
a bug.
target_selection.py:
A number of my comments look like they're being deferred (error messages
and such). Please file bugs for them.
475,631: It's unclear why dataset options are not allowed if we have the
ability to create file systems and zvols. The issues don't seem any
different than for a new pool.
1440: Appending the s0 seems sketchy here; it'll be true on root pools
that are whole disk, but not on non-root pools using whole disks (at
least as far as ZFS reports; is there a layer between you and ZFS that
is modifying this?)
2133: the changes here seem to result in adding a slice to non-root
pools, which seems unnecessary and undesirable
Dave
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
