Hi Darren.
I re-reviewed the stuff I brought up earlier, plus double-checked
Makefile and other logistic files for Derived Manifest project files vs
slim_source.
usr/src/cmd/Makefile.targ:
98-100, 147-149: Remove ROOTPYTHONVENDORSOLINSTALLAICHKPTDMMTEST
as DMM tests are no longer "delivered" to the proto area.
install_common/__init__.py:
comment refers to /var/run instead of /system/volatile
target_selection.py:
nit: Can combine 2098 and 2100 into a single "if"
auto-install/Makefile:
Note: I'll hold back on additional comments on the lack of a .po file as
the G11N team is working on a new way of receiving localizable files.
Thanks,
Jack
On 05/18/11 03:46 PM, Darren Kenny wrote:
Hi,
I think it's about time I got out another version of the code review for the CUD
AI project.
I've uploaded the webrev at:
http://cr.opensolaris.org/~dkenny/cud_ai-to-slim-2/
And for anyone that's reviewed the code before, there is a diff:
http://cr.opensolaris.org/~dkenny/cud_ai-to-slim-2-diffs/
target_selection.py has probably changed the most, so if time is short, we'd
really appreciate you reviewing that file at least.
If at all possible could you please provide any feedback by Friday COB.
Thanks,
Darren.
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
