Hi Dave.
When I reviewed I wondered the same thing... It appears that all
modules which use the progress monitor set "done" in a "finally" clause
for exception handling that envelops the transfer, so it seems safe to
me. The thing I was wondering is who's responsibility is it to guard
against hanging?
If it is the progress monitor itself that is responsible, then maybe a
heartbeat or timeout mechanism is needed where the client module (ips or
cpio) periodically hits a variable to let the monitor know the client
is still alive. But maybe this is over-engineering for our purposes.
If it is the client module that is responsible, then things look fine to
me the way they are.
Thanks,
Jack
On 06/16/11 08:29 AM, Dave Miner wrote:
On 06/16/11 02:58 AM, Karen Tung wrote:
Hi,
I would like to get a code review for the changes to fix the
following bug:
7050253 Net boot text installer hangs all the time in systems with 8 GB
or more memory.
webrev:
http://cr.opensolaris.org/~ktung/7050253/
Karen, the only question I had is whether there's any way the file
system creation fails and leaves things hung up in the loop at 88-89
here?
Dave
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
