On 06/16/11 01:50 PM, Karen Tung wrote:
On 06/16/11 08:29, Dave Miner wrote:
On 06/16/11 02:58 AM, Karen Tung wrote:
Hi,
I would like to get a code review for the changes to fix the
following bug:
7050253 Net boot text installer hangs all the time in systems with 8 GB
or more memory.
webrev:
http://cr.opensolaris.org/~ktung/7050253/
Karen, the only question I had is whether there's any way the file
system creation fails and leaves things hung up in the loop at 88-89
here?
Hi Dave,
That's a good point. Fortunately, file system creation error will not
happen in any the
usage of our installers, because the filesystem being monitored
is the install target, /a, which is already created by the
target instantiation code, before any type of transfer is called.
To address this problem, I can wrap the lines 88-89 in a try/except clause
so in case anything other than OSError is raised by the __fssize()
function, the prog_init_completed flag can be set. Then, I will re-raise
the exception so it can be dealt with by the callers.
Sounds good, Karen.
Dave
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
