Niall,
393 - I know this code was more or less lifted from the old ict
implementation, but can you change this to using devprop(1M)? It will
simplify this entire function. For example, to get the console dev
property value, you'd just do the following (the following is in shell
however):
cons_val = `devprop -s console`
7055231 was recently filed to fix this throughout our install code, and
this lifted code from libict_pymod/ict.py was one of the places
identified that needed to change. So it'd be nice if we don't
perpetuate this here.
thanks,
-ethan
On 06/20/11 10:12, Niall Power wrote:
Hi,
I'd like to ask for a review for my fix for bugster 7051340:
x86 machines unable to boot after textinstall and auto_install if you
use tipline
http://monaco.sfbay.sun.com/detail.jsf?cr=7051340
Webrev is located at:
http://cr.opensolaris.org/~niall/webrev-7051340/
The fix is largely ported from ICTS in libict_pymod but some aspects
need to
be modified to work within the pybootmgmt based environment of the CUD
boot checkpoint:
- bootenv.rc is managed by pybootmgmt from the BootInstance object.
- Grub menu.lst is not directly modified to disable splash. Instead we
disable PROP_CONSOLE_GFX
on the BootLoader object.
- Misc. Parse output of prtconf(1M) directly instead of piping through
sed and cut.
pep8 clean and unit tested.
Thanks,
Niall
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
