Looks good to me Niall.

BTW, is there anyway people could w/around this in the mean-time by adding some
boot configuration to the XML manifest?

Thanks,

Darren.

On 20/06/2011 18:12, Niall Power wrote:
> Hi,
> 
> I'd like to ask for a review for my fix for bugster 7051340:
> x86 machines unable to boot after textinstall and auto_install if you 
> use tipline
> 
> http://monaco.sfbay.sun.com/detail.jsf?cr=7051340
> 
> Webrev is located at:
> http://cr.opensolaris.org/~niall/webrev-7051340/
> 
> The fix is largely ported from ICTS in libict_pymod but some aspects need to
> be modified to work within the pybootmgmt based environment of the CUD 
> boot checkpoint:
> - bootenv.rc is managed by pybootmgmt from the BootInstance object.
> - Grub menu.lst is not directly modified to disable splash. Instead we 
> disable PROP_CONSOLE_GFX
>    on the BootLoader object.
> - Misc. Parse output of prtconf(1M) directly instead of piping through 
> sed and cut.
> 
> pep8 clean and unit tested.
> 
> Thanks,
> Niall
> _______________________________________________
> caiman-discuss mailing list
> [email protected]
> http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss

Reply via email to