Hi Drew.
I saw you already pushed, but had a question...
Could a hang happen in a dry-run situation? In cpio.py, execute() calls
_transfer(), which calls self.pmon.startmonitor(), that invokes
__progressthread(), which calls __fssize(), all without checking
dry_run. But the directory is created only with dry_run set. I just
wanted to check that the progress monitor is somehow inhibited from
running in a dry run situation. It probably is, through some other
means than checking dry_run directly, but thought I'd ask.
... or if this question somehow does not apply, please let me know.
Thanks,
Jack
On 06/20/11 02:56 PM, Drew Fisher wrote:
Good afternoon!
Could I get a quick code review request for the following bugs:
7001620 <http://monaco.us.oracle.com/detail.jsf?cr=7001620> Transfer
progress monitor output needs to be evaluated
7056984 <http://monaco.us.oracle.com/detail.jsf?cr=7056984> DC builds
got stuck in ba-init in latest slim_source build
http://cr.opensolaris.org/~drewfish/cr_7056984/
Forcing the destination directory to exist cleans up this issue. We
also magically fix 7001620 while we're at it. Magic!
Both Mary and I tested the bits to make sure the ba-init checkpoint
runs clean. We're also in the process of building ISOs but I don't
suspect any problems.
Thanks!
-Drew
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
