Darren,

I thought there was general consensus (at least by Drew!)
that we would remove all "pylint disable-msg:" comments
from code and just ignore any invalid pylint warnings/errors?
Is there a strong reason that you are introducing new
pylint comments here?

Otherwise, it looks fine.

- Dermot



On 7/19/2011 8:20 AM, Darren Kenny wrote:
Hi,

I'd like to get a quick review of the changes (mainly comments and a variable
name change) for the fix to the bug:

        7067949 nosexunit.audit.TestAuditSolaris_install failure for
                solaris_install/auto_install/utmpx.py

The webrev is at:

        https://cr.opensolaris.org/action/browse/caiman/dkenny/7067949/webrev/

The bug is just PyLint errors that are being generated incorrectly, since the
variables that it thinks are undefined are actually being dynamically created
for the CTYPES use.

Thanks,

Darren.
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss

Reply via email to