I'm withdrawing this CR. Thanks,
Darren. On 19/07/2011 13:53, Drew Fisher wrote: > Darren, > > There's no reason whatsoever to "fix" anything here. Nothing is wrong > with any of the utmpx.py code. > > This is the *perfect* example of why pylint should not used for anything > more than a guide. It is not smart enough to realize that we're > updating the local namespace with ctypes functions, return types and > arguments so it throws these errors. I'm 100% certain > 'users_on_console()' works fine because if it hadn't, we would have seen > errors from it. > > The code changes Darren has proposed are nothing more than comments to > appease a program not smart enough to deal with a moderately complicated > aspect of Python. If it were me, I'd update the bug with why pylint > things something is broken and then close it as NOTABUG. > > -Drew > > > On 7/19/11 1:20 AM, Darren Kenny wrote: >> Hi, >> >> I'd like to get a quick review of the changes (mainly comments and a variable >> name change) for the fix to the bug: >> >> 7067949 nosexunit.audit.TestAuditSolaris_install failure for >> solaris_install/auto_install/utmpx.py >> >> The webrev is at: >> >> https://cr.opensolaris.org/action/browse/caiman/dkenny/7067949/webrev/ >> >> The bug is just PyLint errors that are being generated incorrectly, since the >> variables that it thinks are undefined are actually being dynamically created >> for the CTYPES use. >> >> Thanks, >> >> Darren. >> _______________________________________________ >> caiman-discuss mailing list >> [email protected] >> http://mail.opensolaris.org/mailman/listinfo/caiman-discuss > _______________________________________________ > caiman-discuss mailing list > [email protected] > http://mail.opensolaris.org/mailman/listinfo/caiman-discuss _______________________________________________ caiman-discuss mailing list [email protected] http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
