Kristina,
Looks good.  Some small comments below:
conv.c:
1597 SIZE_ALL

js2ai.1m.txt:
117 consider:  A conversion of the specified package to its Oracle Solaris 11 
equivalent is attempted.
153 consider: "during the translation process using a process " -> "during 
translation using a process"
184 Is->is
212 Is this true:  The primary goal of translating a JumpStart profile is to 
determine the best choice for the ZFS root pool.

William

On 07/19/11 10:44 PM, Kristina Tripp wrote:
https://cr.opensolaris.org/action/browse/caiman/enpointe/CR_7055567/webrev/

7055567  <http://bugs.opensolaris.org/bugdatabase/view_bug.do?bug_id=7055567>  
js2ai add support for converting LDAP entries in profile
7056954  <http://bugs.opensolaris.org/bugdatabase/view_bug.do?bug_id=7056954>  
Add sysidcfg support for locale
7068309  <http://bugs.opensolaris.org/bugdatabase/view_bug.do?bug_id=7068309>  
nosexunit test failure in solaris_install/js2ai/conv.py
7068477  <http://bugs.opensolaris.org/bugdatabase/view_bug.do?bug_id=7068477>  
filesys mirror swap is not being outputed correctly

Unit tests
Pep8

Currently live testing has not be performed.  xml validates and visual 
confirmation of output
Working on getting access to a client/server setup so another round of testing of manifests and sc profiles doing actual AI install can occur.
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss

Reply via email to