Thanks for the review William On Jul 20, 2011, at 7:13 AM, William Schumann wrote:
> Kristina, > Looks good. Some small comments below: > conv.c: > 1597 SIZE_ALL Fixed. > > js2ai.1m.txt: > 117 consider: A conversion of the specified package to its Oracle Solaris 11 > equivalent is attempted. > 153 consider: "during the translation process using a process " -> "during > translation using a process" > 184 Is->is > 212 Is this true: The primary goal of translating a JumpStart profile is to > determine the best choice for the ZFS root pool. I'll feed these man page changes to Alta and they probably go back in a subsequent putback. Yes that was the original goal that Evan set out for the project. But given that we now also do sysidcfg conversion I probably should change that. Thanks for making me think about that statement. As for profiles that's basically a true statement. There so much we still don't support in keywords translations, mainly since there not supported by AI yet. The main goal we try to perform is figuring out what the ZFS root pool is and generating the xml code to cause it to be created. There may be other things we can do but all the churn in manifests has keep me busy so I haven't done much more than add support for swap. The review copy of the man page lists what keywords we support and don't support it probably easier to read than the checked in version http://review.us.oracle.com/review/reviewperf.do?fileId=319565 > William > > On 07/19/11 10:44 PM, Kristina Tripp wrote: >> >> https://cr.opensolaris.org/action/browse/caiman/enpointe/CR_7055567/webrev/ >> >> 7055567 js2ai add support for converting LDAP entries in profile >> 7056954 Add sysidcfg support for locale >> 7068309 nosexunit test failure in solaris_install/js2ai/conv.py >> 7068477 filesys mirror swap is not being outputed correctly >> >> Unit tests >> Pep8 >> >> Currently live testing has not be performed. xml validates and visual >> confirmation of output >> Working on getting access to a client/server setup so another round of >> testing of manifests and sc profiles doing actual AI install can occur. Kristina Tripp, Senior Software Engineer Oracle Revenue Product Engineering 500 Eldorado Blvd, MS UBRM05-171 Broomfield, CO, 80021 Office: 303-272-8655 Email: [email protected] Oracle is committed to developing practices and products that help protect the environment
_______________________________________________ caiman-discuss mailing list [email protected] http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
