Hi Kristina,
It looks good. I just saw one potential minor issue.
conv.py:
In the comment at line 1757 you give pool size inputs including
'existing' but at line 1783 you error when you see that keyword.
Harold
On 07/26/11 10:25 AM, Kristina Tripp wrote:
Please find the following for review
file:///net/dv31.us.oracle.com/nfs1/ws/ktripp/slim_source/webrev/index.html
7068993 <http://bugs.opensolaris.org/bugdatabase/view_bug.do?bug_id=7068993>
if filesys swap is placed before / then valid profile generates error
7070859 <http://bugs.opensolaris.org/bugdatabase/view_bug.do?bug_id=7070859> filesys
mirror<device> <device> all swap is incorrectly being supported
Unit tests
Pep8
Manual Tests of profiles and verification of generated XML
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
