Thank you for the review Harold.
The logic is correct. The comment
# pool <pool name> <pool size> <swap size> <dump size>
# <slice> | mirror [<slice>]+
#
# Input: ${1} - pool name
# ${2} - pool size (num, existing, auto)
# ${3} - swap size (num, auto)
# ${4} - dump size (num, auto)
# ${5} - (mirror, <slice>, rootdisk.s??, any)
# . - (<slice>, rootdisk.s??, any)
Is referring to the format of the Jumpstart pool keyword that we are
translating to the form required by AI. So although a pool size of "existing"
is supported by Jumpstart, js2ai isn't supporting it. Hence at line 1793 we
error when we see that keyword.
- Kristina
On Jul 27, 2011, at 9:23 AM, Harold Shaw wrote:
> Hi Kristina,
>
> It looks good. I just saw one potential minor issue.
>
> conv.py:
> In the comment at line 1757 you give pool size inputs including 'existing'
> but at line 1783 you error when you see that keyword.
>
> Harold
>
> On 07/26/11 10:25 AM, Kristina Tripp wrote:
>>
>> Please find the following for review
>>
>> file:///net/dv31.us.oracle.com/nfs1/ws/ktripp/slim_source/webrev/index.html
>>
>> 7068993 if filesys swap is placed before / then valid profile generates error
>> 7070859 filesys mirror <device> <device> all swap is incorrectly being
>> supported
>>
>> Unit tests
>> Pep8
>> Manual Tests of profiles and verification of generated XML
>>
>> _______________________________________________
>> caiman-discuss mailing list
>> [email protected]
>> http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
>
> _______________________________________________
> caiman-discuss mailing list
> [email protected]
> http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
Kristina Tripp, Senior Software Engineer
Oracle Revenue Product Engineering
500 Eldorado Blvd, MS UBRM05-171
Broomfield, CO, 80021
Office: 303-272-8655
Email: [email protected]
Oracle is committed to developing practices and products that help protect the
environment
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
