Hi Takeshi.

Thanks for your review and guidance on localization changes. I greatly appreciate your help.

On 08/ 2/11 08:09 PM, Takeshi Asano wrote:
Hi Jack,

- I couldn't find .mf update for DC manpages
The DC manifest already had those manpages, so I did not change it. However, based on your email I know now that I will be making changes to it before I am done...
- facet.doc.man=true looks not specified.
I added these to all non-localized files and the dirs that hold them..
 You can use transform like this (which is in ON's transform).
<transform dir file link path=usr/.+/man(/.+)? -> default facet.doc.man true>
I did it manually, for now...

I attached a sample .mf file for your review to verify that I am making the correct changes. For localized files and dirs, I have facet.doc.man=true and facet.locale.ja_JP=true (or facet.locale.zh_CN=true for Chinese). Is this correct? Is this what the transforms will do?

    Thanks,
    Jack


Yes, translations for the manpages will arrive later.

Thanks,
Takeshi

On 2011年08月03日 11:44, Jack Schwartz wrote:
  Hi everyone.

Here is a webrev in preparation for receiving the nroffed manpages from Alta. This webrev is to confirm that the gate (Makefiles, manifests, etc) is ready to go when the manpages come. The manpages in the review are dummies for now. When they come, I'll plop 'em in and push.

Since it looks like non-English manpages will come later, this code review does not account for them.

Webrev:
https://cr.opensolaris.org/action/browse/caiman/schwartz/7068492_1

Bug IDs:
http://monaco.us.oracle.com/detail.jsf?cr=7068492
http://monaco.us.oracle.com/detail.jsf?cr=7068493
http://monaco.us.oracle.com/detail.jsf?cr=7068495
http://monaco.us.oracle.com/detail.jsf?cr=7068499
http://monaco.us.oracle.com/detail.jsf?cr=7068501
http://monaco.us.oracle.com/detail.jsf?cr=7068503
http://monaco.us.oracle.com/detail.jsf?cr=7074307

Please bless.

    Thanks,
    Jack


------------------------------------------------------------------------

_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss


#
# CDDL HEADER START
#
# The contents of this file are subject to the terms of the
# Common Development and Distribution License (the "License").
# You may not use this file except in compliance with the License.
#
# You can obtain a copy of the license at usr/src/OPENSOLARIS.LICENSE
# or http://www.opensolaris.org/os/licensing.
# See the License for the specific language governing permissions
# and limitations under the License.
#
# When distributing Covered Code, include this CDDL HEADER in each
# file and include the License file at usr/src/OPENSOLARIS.LICENSE.
# If applicable, add the following below this CDDL HEADER, with the
# fields enclosed by brackets "[]" replaced with your own identifying
# information: Portions Copyright [yyyy] [name of copyright owner]
#
# CDDL HEADER END
#
#
# Copyright (c) 2010, 2011, Oracle and/or its affiliates. All rights reserved.
#

set name=pkg.fmri value=pkg:/install/distribution-constructor@$(PKGVERS)
set name=pkg.description \
    value="Distribution Constructor libraries, commands and data files"
set name=pkg.summary value="distro_const utility"
set name=info.classification \
    value="org.opensolaris.category.2008:Applications/System Utilities"
set name=variant.arch value=$(ARCH)
set name=variant.opensolaris.zone value=global value=nonglobal
dir path=etc group=sys
dir path=etc/security group=sys
dir path=etc/security/exec_attr.d group=sys
dir path=etc/security/prof_attr.d group=sys
dir path=usr group=sys
dir path=usr/bin
dir path=usr/lib
dir path=usr/lib/python2.6
dir path=usr/lib/python2.6/vendor-packages
dir path=usr/lib/python2.6/vendor-packages/solaris_install
dir path=usr/lib/python2.6/vendor-packages/solaris_install/distro_const
dir \
    
path=usr/lib/python2.6/vendor-packages/solaris_install/distro_const/checkpoints
dir \
    
path=usr/lib/python2.6/vendor-packages/solaris_install/distro_const/checkpoints/defaultfiles
dir \
    
path=usr/lib/python2.6/vendor-packages/solaris_install/distro_const/checkpoints/xslt
dir path=usr/share group=sys
dir path=usr/share/distro_const
dir path=usr/share/distro_const/profile
dir path=usr/share/distro_const/sort
dir facet.doc.man=true path=usr/share/man
dir facet.doc.man=true facet.local.ja_JP=true \
    path=usr/share/man/ja_JP.UTF8
dir facet.doc.man=true facet.local.ja_JP=true \
    path=usr/share/man/ja_JP.UTF8/man1m
dir facet.doc.man=true facet.local.ja_JP=true \
    path=usr/share/man/ja_JP.UTF8/man4
dir facet.doc.man=true path=usr/share/man/man1m
dir facet.doc.man=true path=usr/share/man/man4
dir facet.doc.man=true facet.local.zh_CN=true \
    path=usr/share/man/zh_CN.UTF8
dir facet.doc.man=true facet.local.zh_CN=true \
    path=usr/share/man/zh_CN.UTF8/man1m
dir facet.doc.man=true facet.local.zh_CN=true \
    path=usr/share/man/zh_CN.UTF8/man4
file path=etc/security/exec_attr.d/distribution-constructor group=sys
file path=etc/security/prof_attr.d/distribution-constructor group=sys
file path=usr/bin/distro_const mode=0555
file path=usr/bin/proc_slist mode=0555
file path=usr/bin/proc_tracedata mode=0555
$(i386_ONLY)file path=usr/bin/usbcopy mode=0555
$(i386_ONLY)file path=usr/bin/usbgen mode=0555
file \
    
path=usr/lib/python2.6/vendor-packages/solaris_install/distro_const/__init__.py 
\
    mode=0444
file \
    
path=usr/lib/python2.6/vendor-packages/solaris_install/distro_const/__init__.pyc
 \
    mode=0444
file \
    
path=usr/lib/python2.6/vendor-packages/solaris_install/distro_const/checkpoints/__init__.py
 \
    mode=0444
file \
    
path=usr/lib/python2.6/vendor-packages/solaris_install/distro_const/checkpoints/__init__.pyc
 \
    mode=0444
file \
    
path=usr/lib/python2.6/vendor-packages/solaris_install/distro_const/checkpoints/ai_publish_pkg.py
 \
    mode=0444
file \
    
path=usr/lib/python2.6/vendor-packages/solaris_install/distro_const/checkpoints/ai_publish_pkg.pyc
 \
    mode=0444
file \
    
path=usr/lib/python2.6/vendor-packages/solaris_install/distro_const/checkpoints/boot_archive_archive.py
 \
    mode=0444
file \
    
path=usr/lib/python2.6/vendor-packages/solaris_install/distro_const/checkpoints/boot_archive_archive.pyc
 \
    mode=0444
file \
    
path=usr/lib/python2.6/vendor-packages/solaris_install/distro_const/checkpoints/boot_archive_configure.py
 \
    mode=0444
file \
    
path=usr/lib/python2.6/vendor-packages/solaris_install/distro_const/checkpoints/boot_archive_configure.pyc
 \
    mode=0444
file \
    
path=usr/lib/python2.6/vendor-packages/solaris_install/distro_const/checkpoints/create_iso.py
 \
    mode=0444
file \
    
path=usr/lib/python2.6/vendor-packages/solaris_install/distro_const/checkpoints/create_iso.pyc
 \
    mode=0444
file \
    
path=usr/lib/python2.6/vendor-packages/solaris_install/distro_const/checkpoints/create_usb.py
 \
    mode=0444
file \
    
path=usr/lib/python2.6/vendor-packages/solaris_install/distro_const/checkpoints/create_usb.pyc
 \
    mode=0444
file \
    
path=usr/lib/python2.6/vendor-packages/solaris_install/distro_const/checkpoints/custom_script.py
 \
    mode=0444
file \
    
path=usr/lib/python2.6/vendor-packages/solaris_install/distro_const/checkpoints/custom_script.pyc
 \
    mode=0444
file \
    
path=usr/lib/python2.6/vendor-packages/solaris_install/distro_const/checkpoints/defaultfiles/rtc_config.default
 \
    mode=0444
file \
    
path=usr/lib/python2.6/vendor-packages/solaris_install/distro_const/checkpoints/pkg_img_mod.py
 \
    mode=0444
file \
    
path=usr/lib/python2.6/vendor-packages/solaris_install/distro_const/checkpoints/pkg_img_mod.pyc
 \
    mode=0444
file \
    
path=usr/lib/python2.6/vendor-packages/solaris_install/distro_const/checkpoints/pre_pkg_img_mod.py
 \
    mode=0444
file \
    
path=usr/lib/python2.6/vendor-packages/solaris_install/distro_const/checkpoints/pre_pkg_img_mod.pyc
 \
    mode=0444
file \
    
path=usr/lib/python2.6/vendor-packages/solaris_install/distro_const/checkpoints/xslt/doc2_media_transfer.xslt
 \
    mode=0444
file \
    path=usr/lib/python2.6/vendor-packages/solaris_install/distro_const/cli.py \
    mode=0444
file \
    path=usr/lib/python2.6/vendor-packages/solaris_install/distro_const/cli.pyc 
\
    mode=0444
file \
    
path=usr/lib/python2.6/vendor-packages/solaris_install/distro_const/distro_spec.py
 \
    mode=0444
file \
    
path=usr/lib/python2.6/vendor-packages/solaris_install/distro_const/distro_spec.pyc
 \
    mode=0444
file \
    
path=usr/lib/python2.6/vendor-packages/solaris_install/distro_const/execution_checkpoint.py
 \
    mode=0444
file \
    
path=usr/lib/python2.6/vendor-packages/solaris_install/distro_const/execution_checkpoint.pyc
 \
    mode=0444
file path=usr/share/distro_const/boot_archive_contents_sparc.xml group=sys \
    mode=0444
file path=usr/share/distro_const/boot_archive_contents_x86.xml group=sys \
    mode=0444
file path=usr/share/distro_const/dc_ai_sparc.xml group=sys mode=0444
file path=usr/share/distro_const/dc_ai_x86.xml group=sys mode=0444
file path=usr/share/distro_const/dc_livecd.xml group=sys mode=0444
file path=usr/share/distro_const/dc_text_sparc.xml group=sys mode=0444
file path=usr/share/distro_const/dc_text_x86.xml group=sys mode=0444
file path=usr/share/distro_const/lang_facets.xml group=sys mode=0444
file path=usr/share/distro_const/profile/ai.xml group=sys mode=0444
file path=usr/share/distro_const/profile/generic.xml group=sys mode=0444
file path=usr/share/distro_const/profile/livecd.xml group=sys mode=0444
file path=usr/share/distro_const/profile/text.xml group=sys mode=0444
file path=usr/share/distro_const/sort/livecd.sort group=sys mode=0444
file path=usr/share/distro_const/sort/text_x86.sort group=sys mode=0444
file facet.doc.man=true facet.local.ja_JP=true \
    path=usr/share/man/ja_JP.UTF8/man1m/distro_const.1m mode=0444
file facet.doc.man=true facet.local.ja_JP=true \
    path=usr/share/man/ja_JP.UTF8/man4/dc_manifest.4 mode=0444
file facet.doc.man=true path=usr/share/man/man1m/distro_const.1m mode=0444
file facet.doc.man=true path=usr/share/man/man4/dc_manifest.4 mode=0444
file facet.doc.man=true facet.local.zh_CN=true \
    path=usr/share/man/zh_CN.UTF8/man1m/distro_const.1m mode=0444
file facet.doc.man=true facet.local.zh_CN=true \
    path=usr/share/man/zh_CN.UTF8/man4/dc_manifest.4 mode=0444
license cr_Sun license=cr_Sun

# /usr/bin/gunzip
depend fmri=compress/gzip type=require
# /usr/bin/7za
depend fmri=compress/p7zip type=require
# /usr/bin/mkisofs
depend fmri=media/cdrtools type=require
# /usr/bin/rmformat
depend fmri=service/storage/media-volume-manager type=require
# /usr/bin/awk
depend fmri=system/extended-system-utilities type=require
# /usr/sbin/zfs
depend fmri=system/file-system/zfs type=require
# /usr/xpg4/bin/grep
depend fmri=system/xopen/xcu4 type=require
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss

Reply via email to