Hi Takeshi and Dave.
Thanks for your comments. I have changed the following:
1) ja_JP and zh_CN locales are added.
2) Transforms are used.
This review is what the gate will look like when both localized and
C-locale manpages are delivered. If this looks good to you, I will
maintain this structure as I proceed with delivering the manpages. I
will deliver nroffed non-localized manpages for 172, and will file
another bug (probably just one) and deliver all localized manpages going
back to 173.
Webrev:
https://cr.opensolaris.org/action/browse/caiman/schwartz/7068492_2/webrev/
As before, this webrev uses dummy manpages.
While making my changes, I noticed a latent bug in the ON transform for
facet.doc.man. It will match any file that has a branch in the middle
of its path that starts with "man", for example:
/usr/sbin/manager/program
which, if it existed, would probably not be a manpage. Fortunately ON
doesn't have any files that match that pattern, so the problem has not
shown up. However, the install gate has files which do match that
pattern. The fix is simply to add a "$" to the end of the pattern,
which I do in my changes:
<transform dir file link path=usr/.+/man(/.+)?$ -> default facet.doc.man
true>
For the record, I have filed:
7075304 facet.doc.man transform could hit more than just manpage entries
against the ON consolidation.
Thanks,
Jack
On 08/ 3/11 08:55 PM, Dave Miner wrote:
On 08/ 3/11 10:49 PM, Takeshi Asano wrote:
Hi Jack,
On 2011年08月04日 08:27, Jack Schwartz wrote:
Hi Takeshi.
Thanks for your review and guidance on localization changes. I greatly
appreciate your help.
On 08/ 2/11 08:09 PM, Takeshi Asano wrote:
Hi Jack,
- I couldn't find .mf update for DC manpages
The DC manifest already had those manpages, so I did not change it.
I see. Thank you.
However, based on your email I know now that I will be making changes
to it before I am done...
- facet.doc.man=true looks not specified.
I added these to all non-localized files and the dirs that hold them
You can use transform like this (which is in ON's transform).
<transform dir file link path=usr/.+/man(/.+)? -> default
facet.doc.man true>
I did it manually, for now...
It's your choice whether to use transform or statically have
in manifest sources. Please take care to have facets correctly
when manpages are added in the future.
Jack, please use pkgmogrify transforms whenever possible. They are
easier to maintain and less error-prone than manually tagging actions.
Dave
I attached a sample .mf file for your review to verify that I am
making the correct changes. For localized files and dirs, I have
facet.doc.man=true and facet.locale.ja_JP=true (or
facet.locale.zh_CN=true for Chinese). Is this correct? Is this what
the transforms will do?
I noticed two points:
- You have typos facet.local.{ja_JP|zh_CN| in the file. 'e' is missing.
They should be facet.locale.{ja_JP|zh_CN}.
- The transform adds both facet.locale.zh_CN=true and
facet.locale.zh_SG=true
to zh_CN.UTF-8 dirs/files so if you want to have equivalent statically
please add facet.locale.zh_SG=true.
BTW, as I wrote in the CR, the translated files will arrive by snv_173.
They will not arrive by snv_172. So as far as you're targeting snv_172
for English integration, please comment out actions for translations, or
put copies of English files as placeholders until the translated ones
arrive.
Thanks,
Takeshi
Thanks,
Jack
Yes, translations for the manpages will arrive later.
Thanks,
Takeshi
On 2011年08月03日 11:44, Jack Schwartz wrote:
Hi everyone.
Here is a webrev in preparation for receiving the nroffed manpages
from Alta. This webrev is to confirm that the gate (Makefiles,
manifests, etc) is ready to go when the manpages come. The manpages
in the review are dummies for now. When they come, I'll plop 'em in
and push.
Since it looks like non-English manpages will come later, this code
review does not account for them.
Webrev:
https://cr.opensolaris.org/action/browse/caiman/schwartz/7068492_1
Bug IDs:
http://monaco.us.oracle.com/detail.jsf?cr=7068492
http://monaco.us.oracle.com/detail.jsf?cr=7068493
http://monaco.us.oracle.com/detail.jsf?cr=7068495
http://monaco.us.oracle.com/detail.jsf?cr=7068499
http://monaco.us.oracle.com/detail.jsf?cr=7068501
http://monaco.us.oracle.com/detail.jsf?cr=7068503
http://monaco.us.oracle.com/detail.jsf?cr=7074307
Please bless.
Thanks,
Jack
------------------------------------------------------------------------
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
