Ginnie,
Thanks for reviewing.
On 08/03/11 10:04, Virginia Wray wrote:
Hi Ethan --
A couple of comments for the man page. The rest looks good.
ginnie
ai_manifest.4.txt
----------------------
ln 46: remove one of the "was"
done
ln 60: a the zone gets installed - remove either "a" or "the"
done
ln 134: Should this be a separate bullet item? It seems like it goes
with the previous one.
It actually is trying to speak to how we, by default, choose to create a
swap and dump zvol, so I think its a separate point. I've changed it to:
- Creation of a swap zvol, and a dump zvol, in the root pool, space
permitting.
ln 200: what is seen when by running - remove either "when or "by"
removed "by"
ln 209 - 211 and on.... not sure what that is, but I assume it won't
appear in the final.
Its special tagging interpreted by nroff. (The don't show up when you
run this file through 'man') I've surrounded all of the lines that show
example XML code by these markers so that they don't get wrapped around
at 66 chars (or whatever the number is) and is allowed to extend to the
end of the screen. We do this in most all of our man pages that display
examples.
ln 335: source of of the iSCSI - remove one "of'
done
ln 549: this sentence seems incomplete
I've changed it to: If this slice does not exist, it will be skipped
over and a warning will be given.
ln 628: be the a swap zvol - remove either 'the" or "a"
removed 'the'
ln 636: the same as 628
removed 'the'
ln 910: this is really a nit, but "it's" should actually be "its" (no
apostrophe)
done
ln 929: should be "is inherited"
done
ln 948: "as" should be "has"
done
ln 976: same as 948
done
ln 1045: The order of that the publishers - remove "of" or "that"
removed "of"
ln 1320: default/defaults
done
Thanks,
-ethan
On 08/ 2/11 04:45 PM, Ethan Quach wrote:
Can I get a review for the following bugfix:
BugID:
--------
http://monaco.us.oracle.com/detail.jsf?cr=7025229
(7025229 Need an AI manifest man page)
Webrev:
----------
https://cr.opensolaris.org/action/browse/caiman/equach/7025229/webrev/
thanks,
-ethan
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
