On 08/08/11 18:16, Karen Tung wrote:
Hi Dave,
One small comment:
I think lines 70-74 of usr/src/README needs to be updated
to reflect the changes you are making.
How about the below diff for this?
{badboy} hg diff
diff -r ab9561463a8e usr/src/README
--- a/usr/src/README Mon Aug 08 18:06:52 2011 -0400
+++ b/usr/src/README Mon Aug 08 18:29:14 2011 -0400
@@ -64,14 +64,15 @@
2. cp tools/env/developer.sh .; chmod +w developer.sh
Some environment variables which might need to be changed:
- *You should - set the path to your repository defined by CODEMGR_WS.
- *You may - need to change the SPRO_ROOT variable to point to your
- installed compilers. Likely locations are:
- /opt/sunstudio12.1 (default)
- /opt/solstudioex
- /opt/SUNWspro
+ * You should set the path to your repository defined by CODEMGR_WS.
+ * You may need to change the SPRO_ROOT variable to point to your
+ installed compilers. Likely locations are:
+ /opt/SUNWspro (default)
+ /opt
+ /ws/onnv-tools
- You might want to link SUNWspro to sunstudio12.1 if necessary
+ In some circumstances overriding the SPRO_VROOT variable may be
useful,
+ as well as symlinks from /opt to your compiler location.
Dave
All other changes look good to me.
Thanks,
--Karen
On 08/08/11 15:08, Dave Miner wrote:
On 08/08/11 17:15, Karen Tung wrote:
Hi Dave,
I have a question on your changes to Makefile.master.
Your changes define SPRO_VROOT=$(SPRO_ROOT)/sunstudio12.1
SPRO_ROOT is defined in Makefile.master to be /opt/SUNWspro
because BUILD_TOOLS=/opt.
That means SPRO_VROOT=/opt/SUNWspro/sunstudio12.1
Does that mean I have to install sunstudio12.1 under /opt/SUNWspro?
No. The "normal" thing to do for ON is to get your tools from
/ws/onnv-tools, under which there's SUNWspro/sunstudio12.1. In many
build machines /opt/SUNWspro is a symlink to /ws/onnv-tools/SUNWspro
(or is an rsync'ed copy thereof). The code in nightly is designed to
work with this configuration.
On my system, the pkg:/developer/[email protected] package
is installed into /opt/sunstudio12.1. Does that mean I should make a
symlink?
Honestly, using that package is not the correct thing to do from a CBE
point of view; the CBE uses a version of the compiler that has fixes
to deal with bugs found by ON and other consolidations. For
development purposes your results will usually be "close enough" but
you're at risk of the odd deviant bug. Really not worth the trouble
IMHO unless you're building on a system without convenient LAN access
to the tools cache.
I look at the Makefile.master in ON gate, BUILD_TOOLS is defined to be
/ws/onnv-tools, which does have to correct setup to resolve
SPRO_ROOT and SPRO_VROOT to the correct value.
Right, as noted above.
In the usr/src/README and usr/src/tools/env/developer.sh, SPRO_ROOT
is defined to be /opt/sunstudio12.1, which will make SPRO_VROOT
resolve to /opt/sunsudio12.1/sunstudio12.1, do those 2 files need to
be updated?
Yes, I think it's time I updated that developer.sh and re-aligned that
setting with ON's.
New webrev at
https://cr.opensolaris.org/action/browse/caiman/dminer/slim_7075220_1/webrev/
Dave
Thanks,
--Karen
On 08/08/11 13:49, Dave Miner wrote:
Please review the fixes at
https://cr.opensolaris.org/action/browse/caiman/dminer/slim_7075220/webrev/
Addressing:
7075220 sc_template.xml left behind in cleanup
7061155 Need to fix Makefile.master to SPRO_VROOT due to nightly
change in 7060181
Thanks,
Dave
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
