Dave,
One comment inline.
On 08/08/11 23:08, Dave Miner wrote:
On 08/08/11 17:15, Karen Tung wrote:
Hi Dave,
I have a question on your changes to Makefile.master.
Your changes define SPRO_VROOT=$(SPRO_ROOT)/sunstudio12.1
SPRO_ROOT is defined in Makefile.master to be /opt/SUNWspro
because BUILD_TOOLS=/opt.
That means SPRO_VROOT=/opt/SUNWspro/sunstudio12.1
Does that mean I have to install sunstudio12.1 under /opt/SUNWspro?
No. The "normal" thing to do for ON is to get your tools from
/ws/onnv-tools, under which there's SUNWspro/sunstudio12.1. In many
build machines /opt/SUNWspro is a symlink to /ws/onnv-tools/SUNWspro (or
is an rsync'ed copy thereof). The code in nightly is designed to work
with this configuration.
On my system, the pkg:/developer/[email protected] package
is installed into /opt/sunstudio12.1. Does that mean I should make a
symlink?
Honestly, using that package is not the correct thing to do from a CBE
point of view; the CBE uses a version of the compiler that has fixes to
deal with bugs found by ON and other consolidations. For development
purposes your results will usually be "close enough" but you're at risk
of the odd deviant bug. Really not worth the trouble IMHO unless you're
building on a system without convenient LAN access to the tools cache.
If we're not supposed to use this package, then usr/src/README should
probably be updated to state what we should be using. It currently
states that developer/sunstudio12u1 is the preferred Studio package to
install. If you don't have /ws/onnv-tools available what is the
preferred packages ?
cheers
Matt
I look at the Makefile.master in ON gate, BUILD_TOOLS is defined to be
/ws/onnv-tools, which does have to correct setup to resolve
SPRO_ROOT and SPRO_VROOT to the correct value.
Right, as noted above.
In the usr/src/README and usr/src/tools/env/developer.sh, SPRO_ROOT
is defined to be /opt/sunstudio12.1, which will make SPRO_VROOT
resolve to /opt/sunsudio12.1/sunstudio12.1, do those 2 files need to
be updated?
Yes, I think it's time I updated that developer.sh and re-aligned that
setting with ON's.
New webrev at
https://cr.opensolaris.org/action/browse/caiman/dminer/slim_7075220_1/webrev/
Dave
Thanks,
--Karen
On 08/08/11 13:49, Dave Miner wrote:
Please review the fixes at
https://cr.opensolaris.org/action/browse/caiman/dminer/slim_7075220/webrev/
Addressing:
7075220 sc_template.xml left behind in cleanup
7061155 Need to fix Makefile.master to SPRO_VROOT due to nightly
change in 7060181
Thanks,
Dave
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
