Drew:

Looks good to me and thank you for fixing the tests.

On 08/11/11 08:53 AM, Drew Fisher wrote:
Good morning!

I was hoping to get a quick code review for

6987307 <http://monaco.us.oracle.com/detail.jsf?cr=6987307> Update slim_test to allow better granularity of test selection

https://cr.opensolaris.org/action/browse/caiman/drewfish/6987307/webrev/

This impacts none of our packaged code, so I figured it was safe to send out even though we're in a restricted build phase.

I added a new test script which allows two new things:
- the ability to specify subsets of tests to run rather than running every single test in the gate
- regression testing against prior Hudson results.

The regression testing isn't the smartest algorithm so take that testing with a grain of salt. By default, the new script looks at the latest Hudson install_unit_tests job and compares against that. If somebody pushes something that breaks 50 tests, that will be used as the baseline. I added a flag to the script which allows you to specify which Hudson job you want to compare against should something like that happen.


This is good as well.


The change to tests.nose was to re-include the /lib/install_ict/test directory. It went missing at some point ...

Thanks!

-Drew


_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss

_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss

Reply via email to