On 8/11/11 10:37 AM, John Fischer wrote:
Drew,
Good work here. I didn't know about the stderr/stdout usage of StringIO()
trick. I did that differently. Cool. Comments below.
Thanks,
John
usr/src/tools/tests/slim_regression_test.py
--------------------------------------------------------------------------------------------
1. Would it be better to put these tests within the main function?
38 try:
39 SRC = os.environ["SRC"]
40 except KeyError:
41 print "unable to find $SRC in environment. Please add SRC to "
42 print "/etc/sudoers file under the 'Defaults env_keep=...' section"
43
44 # check permissions
45 if os.geteuid() != 0:
46 raise SystemExit("Error: Root privileges are required")
47
I have to leave the SRC check in the global scope so that optparse can
set up the usage correctly. I could move the permissions check into
main(), but if I'm going to bomb out of the script for a missing
environment variable, I might as well do the same for invalid permissions.
2. Should the following be removed?
63 # XXX why does this not work?
64 #"ai": ["cmd/auto-install/checkpoints/test/",
"cmd/auto-install/test/"],
Or modified to work?
Honestly, I have no idea why it won't work. I'm wondering if one of the
tests is screwing up something within nose. I'll see if I can keep
banging on it but I don't think it should be a stopper.
3. Should 2 word variables within options have consistent separations?
135 parser.add_option("--suppress-results", dest="suppressresults",
138 parser.add_option("--hudson", dest="hudson_num",
i.e., suppressresults and hudsonnum verses suppress_results and
hudson_num
Fixed.
Thanks, John!
-Drew
On 08/11/11 08:53 AM, Drew Fisher wrote:
Good morning!
I was hoping to get a quick code review for
6987307 <http://monaco.us.oracle.com/detail.jsf?cr=6987307> Update
slim_test to allow better granularity of test selection
https://cr.opensolaris.org/action/browse/caiman/drewfish/6987307/webrev/
This impacts none of our packaged code, so I figured it was safe to
send out even though we're in a restricted build phase.
I added a new test script which allows two new things:
- the ability to specify subsets of tests to run rather than running
every single test in the gate
- regression testing against prior Hudson results.
The regression testing isn't the smartest algorithm so take that
testing with a grain of salt. By default, the new script looks at
the latest Hudson install_unit_tests job and compares against that.
If somebody pushes something that breaks 50 tests, that will be used
as the baseline. I added a flag to the script which allows you to
specify which Hudson job you want to compare against should something
like that happen.
The change to tests.nose was to re-include the /lib/install_ict/test
directory. It went missing at some point ...
Thanks!
-Drew
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
