Hi Dermot,
I have 1 question and 1 comment on the changes.
1) What's the advantage of moving the checks in lines 296-301
of the OLD file down to after passwords are validated?
IMO, those are very simple mistakes to catch, and we shouldn't
waste the cycles to go through with validating the password
if we will eventually fail anyway.
2) Line 321: I think you can change that to an "else". The "if"
in line 312 already checks for "if login_name".
--Karen
On 08/15/11 05:51 AM, Dermot McCluskey wrote:
Hi all (esp. Jan, William, Karen),
I'd like 2 or more reviewers for this fix for sysconfig:
http://monaco.sfbay.sun.com/detail.jsf?cr=7056210
restrictions for setting password in sysconfig does not match "passwd"
command
Webrev:
https://cr.opensolaris.org/action/browse/caiman/dermot/7056210/
The fix involves calling the validate_password()
function (already in use by GUI Install) from the
Sysconfig Users screen for both the user and root
password fields. The validation code code is slightly
restructured to ensure "higher priority" validation
errors are reported first.
This fix has been tested by running the new
sysconfig code in a VM and confirming that
validation of the root and user password
fields behaves as expected.
Thanks,
- Dermot
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
