On 08/15/2011 04:20 PM, Dermot McCluskey wrote:
Jan,
On 08/15/11 14:57, Jan Damborsky wrote:
On 08/15/11 15:49, Dermot McCluskey wrote:
Jan,
Good question! If you fill in the user screen details;
press F2 to advance; then press F3 to go back; then
press F2 again (without changing anything).
In this case, we don't want to validate again, as the
password field contains "**************" unless it is
edited.
I see - got it :-)
Could you please enrich comment with that info,
so that it's captured for future ?
No problem. How about:
+ # Note: the Root and User password fields may be filled with
+ # asterisks if the user previously invoked this screen. Therefore,
+ # if not empty we check their modified flags before validating the
+ # contents.
+
# Root password is mandatory and, if modified, must be valid
...
Yep, that sounds good.
Thank you, Dermot.
Jan
- dermot
Thank you,
Jan
- Dermot
On 08/15/11 14:20, Jan Damborsky wrote:
Hi Dermot,
the changes look good to me.
I have just a question related to cases when password
validation is skipped:
...
# Root password is mandatory and, if modified, must be valid
if not root_pass_set or self.root_pass_edit.modified:
...
What are the cases when self.root_pass_edit.modified is False
and why we don't validate passwords in such scenarios ?
Thank you,
Jan
On 08/15/11 14:51, Dermot McCluskey wrote:
Hi all (esp. Jan, William, Karen),
I'd like 2 or more reviewers for this fix for sysconfig:
http://monaco.sfbay.sun.com/detail.jsf?cr=7056210
restrictions for setting password in sysconfig does not match "passwd" command
Webrev:
https://cr.opensolaris.org/action/browse/caiman/dermot/7056210/
The fix involves calling the validate_password()
function (already in use by GUI Install) from the
Sysconfig Users screen for both the user and root
password fields. The validation code code is slightly
restructured to ensure "higher priority" validation
errors are reported first.
This fix has been tested by running the new
sysconfig code in a VM and confirming that
validation of the root and user password
fields behaves as expected.
Thanks,
- Dermot
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
