Hi Martin,
You are using errno.EEXIST in line 258 but you never import
the errno module. I think you need to import that module.
The fact that you don't see any error about the errno module
is not imported means in your testing, you don't ever get
into the race condition, so, the code in line 258 is never executed
in your testing. The code should be able to fix the race condition.
If the team that reported it can easily recreate the problem, it would
be best for them to verify your fix.
Thanks,
--Karen
On 08/15/11 11:46 PM, Martin Widjaja wrote:
Hi all,
Can I request at least 2 reviewers for this quite simple fix for bug
7066541?
*7066541 installing several zones in parallel sometimes fail: [Errno
17] File exists: '/var/tmp/install'
<http://monaco.sfbay.sun.com/detail.jsf?cr=7066541>*
Webrev is here:
https://cr.opensolaris.org/action/browse/caiman/widjaja/7066541/webrev/
I don't have much luck trying to create the issue listed in the CR
during multiple zone installs in parallel. I have tried many methods,
including the use of a script to run 5 zone installs, and have
executed this over and over, but so far I have not been able to create
the race condition (system too slow?). At this point I am requesting
the filer to help test since he seems to be able to produce the race
condition much more easily and consistently.
Good news is I've tested this multiple times, and no regression is
seen so far.
Additionally, I've created a slightly different version for detecting
the race condition during testing by adding an else/print statement
corresponding to the if statement on line 258.
That version of the file can be copied from
10.132.145.50:/export/home/mwidjaja/logger.py.
If anyone has a better idea on producing a much more frequent and
consistent race condition for a parallel zone installs, please let me
know.
Thanks,
Martin
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
