Looks good to me.
--Karen
On 08/16/11 06:24 PM, Martin Widjaja wrote:
Hi,
Round 2 review for bug 7066541.
*7066541 installing several zones in parallel sometimes fail: [Errno
17] File exists: '/var/tmp/install'
<http://monaco.sfbay.sun.com/detail.jsf?cr=7066541>*
Webrev:
https://cr.opensolaris.org/action/browse/caiman/widjaja/7066541_rnd_2/webrev/
This includes Ethan's request to fix the later error exploited in the
bug report where instantiation of AutoInstall class in auto-install.py
didn't happen properly for whatever reason.
Python folks should review and comment on whether what I am doing is
python enough or if it's even valid. Trying it out in python shell
seems to work fine.
Thanks,
Martin
On 8/15/2011 11:46 PM, Martin Widjaja wrote:
Hi all,
Can I request at least 2 reviewers for this quite simple fix for bug
7066541?
*7066541 installing several zones in parallel sometimes fail: [Errno
17] File exists: '/var/tmp/install'
<http://monaco.sfbay.sun.com/detail.jsf?cr=7066541>*
Webrev is here:
https://cr.opensolaris.org/action/browse/caiman/widjaja/7066541/webrev/
I don't have much luck trying to create the issue listed in the CR
during multiple zone installs in parallel. I have tried many methods,
including the use of a script to run 5 zone installs, and have
executed this over and over, but so far I have not been able to
create the race condition (system too slow?). At this point I am
requesting the filer to help test since he seems to be able to
produce the race condition much more easily and consistently.
Good news is I've tested this multiple times, and no regression is
seen so far.
Additionally, I've created a slightly different version for detecting
the race condition during testing by adding an else/print statement
corresponding to the if statement on line 258.
That version of the file can be copied from
10.132.145.50:/export/home/mwidjaja/logger.py.
If anyone has a better idea on producing a much more frequent and
consistent race condition for a parallel zone installs, please let me
know.
Thanks,
Martin
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
