Matt,
This error will show up for any disk in which we format -L vtoc fails.
It doesn't have to be a FC connected disk. It will also ONLY show up on
SPARC machines (as we don't auto-label x86 disks).
I'll change it to Jesse and Sue's suggested wording and leave everything
as .info() for now. If this generates bugs, we'll adjust as needed.
Sound OK?
-Drew
On 8/17/11 11:05 AM, Matt Keenan wrote:
Drew,
Looks fine to me, as this will show up for disks attached to two
controllers, how frequent are users likely to see this message ?
If somewhat infrequent then I'm happy with what is here now, however
if it's going to appear a lot then changing the error from info to
debug to be would be the best route.
cheers
Matt
On 08/17/11 16:33, Drew Fisher wrote:
Good morning!
Could I please get a code review for:
7071109 <http://monaco.us.oracle.com/detail.jsf?cr=7071109> AI
installer confused by FC disk connected via two controllers
https://cr.opensolaris.org/action/browse/caiman/drewfish/7071109/webrev/
Here's the sample output as shown by AI:
15:19:18 Install Log: /system/volatile/install_log
15:19:18 Using XML Manifest: ai.xml
15:19:18 Starting installation.
15:19:18 0% Preparing for Installation
15:19:18 100% manifest-parser completed.
15:19:19 0% Preparing for Installation
15:19:19 1% Preparing for Installation
15:19:19 3% Preparing for Installation
15:19:23 c2t200700A0B821AA6Cd0 is unlabeled. Forcing a VTOC label
15:19:30 Unable to label c2t200700A0B821AA6Cd0: Current Disk Type
is not set.
15:19:44 20% target-discovery completed.
15:19:44 === Executing Target Selection Checkpoint ==
15:19:44 Selected Disk(s) : c3t0d0
15:19:45 67% target-selection completed.
15:19:45 99% ai-configuration completed.
Jesse raised a concern that that error really sticks out and it may
cause additional bugs to be filed. I wanted to run that issue past
C-D to find out how we want to handle an error with forcing the label
to the disk.
options:
- Move the .info() calls to .debug() to hide them
- Add additional comments like: "unless this is your install volume,
you can safely ignore this" to try to minimize the issue
- other?
Thanks!
-Drew
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
