Thanks, Jack.
I nuked the comment and changed the output string to look like:
16:57:22 c2t200700A0B821AA6Cd0 is unlabeled. Forcing a VTOC label
16:57:30 Warning: unable to label c2t200700A0B821AA6Cd0: Current
Disk Type is not set.
This warning can be ignored, unless the disk is your install volume.
16:57:43 20% target-discovery completed.
16:57:44 === Executing Target Selection Checkpoint ==
-Drew
On 8/17/11 11:05 AM, Jack Schwartz wrote:
Hi Drew.
I agree with Jesse about removing 687, and I agree with Sue about
making that error message an explicit warning and relevant only on
install targets. I assume users will see error messages when such
disks are later slated for install targets but have no label. So they
should be able to put 2 and 2 together at that point.
Thanks,
Jack
On 08/17/11 08:33 AM, Drew Fisher wrote:
Good morning!
Could I please get a code review for:
7071109 <http://monaco.us.oracle.com/detail.jsf?cr=7071109> AI
installer confused by FC disk connected via two controllers
https://cr.opensolaris.org/action/browse/caiman/drewfish/7071109/webrev/
Here's the sample output as shown by AI:
15:19:18 Install Log: /system/volatile/install_log
15:19:18 Using XML Manifest: ai.xml
15:19:18 Starting installation.
15:19:18 0% Preparing for Installation
15:19:18 100% manifest-parser completed.
15:19:19 0% Preparing for Installation
15:19:19 1% Preparing for Installation
15:19:19 3% Preparing for Installation
15:19:23 c2t200700A0B821AA6Cd0 is unlabeled. Forcing a VTOC label
15:19:30 Unable to label c2t200700A0B821AA6Cd0: Current Disk Type
is not set.
15:19:44 20% target-discovery completed.
15:19:44 === Executing Target Selection Checkpoint ==
15:19:44 Selected Disk(s) : c3t0d0
15:19:45 67% target-selection completed.
15:19:45 99% ai-configuration completed.
Jesse raised a concern that that error really sticks out and it may
cause additional bugs to be filed. I wanted to run that issue past
C-D to find out how we want to handle an error with forcing the label
to the disk.
options:
- Move the .info() calls to .debug() to hide them
- Add additional comments like: "unless this is your install volume,
you can safely ignore this" to try to minimize the issue
- other?
Thanks!
-Drew
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
