I'm good on both accounts. I missed that you were in a loop for
first_disk ... No need for a re-review.
-Drew
On 8/18/11 9:45 PM, John Fischer wrote:
Drew,
Thanks for the review. I'll make the 2 changes you mention. Let me know
if the explanation for the first_disk clears things up for you. Also let me
know
if you want a second round of review.
Thanks,
John
On Aug 18, 2011, at 7:18 PM, Drew Fisher wrote:
John,
confirm_screen.py
----------------
177-184: I'm not seeing how first_disk *couldn't* be None. Am I missing
something?
So the first time through the loop first_disk is None. However, if there are
multiple disks
then when the loop walks the disks it will no longer be None on the second and
subsequent
iterations.
184: change to: if first_disk is None:
Will change.
disk_screen.py
-------------
785: change to: if active_button is not None
Will change.
-Drew
On 8/18/11 7:56 PM, John Fischer wrote:
All,
Can I get a review for CR 7080703:
http://monaco.us.oracle.com/detail.jsf?cr=7080703
7080703 [A11Y] several accessibility regressions within the new GUI
Installer
The webrev is located at:
https://cr.opensolaris.org/action/browse/caiman/johnfisc/7080703/
This is a high priority fix because the install has several regressions in
terms of
accessibility. I've already sent email to Dave asking for integration approval
which
he granted.
The fix for this is to make sure that the appropriate widget has focus
when entering the screen. For example, the welcomewindow widget
should have focus on the Welcome Screen. This a is low risk fix.
I have installed a system with and without using Accessibility technology.
All installs now work properly.
Thanks,
John
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
