Dermot, Sounds good. I implement the no target disks and test.
John On Aug 19, 2011, at 3:05 AM, Dermot McCluskey wrote: > Ho John, > > Other than Drew's comments, I have two small > suggestions. No need for a new webrev. > > > confirm_screen.py > change: > > 189 first_disk.grab_focus() > > to : > > 189 if first_disk is not None: > > 190 first_disk.grab_focus() > > > (although we should never get this far is there are no > target disks, it's seems like the right thing to do?) > > > disk_screen.py: > Should we also add a grab focus for the "busy" version > of this screen? Maybe something like: > @@ -712,7 +712,8 @@ > > # Only create the widgets which don't come from Glade once > if self._finding_disks_vbox is None: > - self._finding_disks_vbox = self._create_finding_disks_vbox() > + self._finding_disks_vbox, busy_label = \ > + self._create_finding_disks_vbox() > > empty_container(self._disksviewport) > self._disksviewport.add(self._finding_disks_vbox) > @@ -720,6 +721,8 @@ > self._disksviewport.show_all() > self._toplevel.show() > > + busy_label.grab_focus() > + > self.set_back_next(back_sensitive=True, next_sensitive=False) > > def _show_screen_for_td_complete(self): > @@ -838,7 +841,7 @@ > finding_disks_vbox.pack_end(busyimage, expand=False, > fill=False, padding=0) > > - return finding_disks_vbox > + return finding_disks_vbox, label > > def _create_disk_button_icon(self, disk): > ''' > > Thanks, > - Dermot > > > On 08/19/11 02:56, John Fischer wrote: >> All, >> >> Can I get a review for CR 7080703: >> >> http://monaco.us.oracle.com/detail.jsf?cr=7080703 >> 7080703 [A11Y] several accessibility regressions within the new GUI >> Installer >> >> The webrev is located at: >> >> https://cr.opensolaris.org/action/browse/caiman/johnfisc/7080703/ >> >> This is a high priority fix because the install has several regressions in >> terms of >> accessibility. I've already sent email to Dave asking for integration >> approval which >> he granted. >> >> The fix for this is to make sure that the appropriate widget has focus >> when entering the screen. For example, the welcomewindow widget >> should have focus on the Welcome Screen. This a is low risk fix. >> >> I have installed a system with and without using Accessibility technology. >> All installs now work properly. >> >> Thanks, >> >> John >> _______________________________________________ >> caiman-discuss mailing list >> [email protected] >> http://mail.opensolaris.org/mailman/listinfo/caiman-discuss _______________________________________________ caiman-discuss mailing list [email protected] http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
