Hi Matt, Generally, looks fine, but one thing that I think might be worth considering is whether the 'cut -f2 -d=' would be better as "cut -f2- -d=' to allow for other uses of the possible values going forward (e.g. a HTTP url, or similar).
The difference is that if you have 'a=b=c', yours would return 'b', while the other version would return 'b=c' is is probably more like what is desired. On another (but related note) maybe this is the time to make the changes in this script at least to move from parsing prtconf output to using devprop. Dave/Ethan, what do you think? Thanks, Darren. On 23/08/2011 12:51, Matt Keenan wrote: > Hi, > > Can I get two pairs of eyes for : > > 6990832 AI usage of the 'prompt' bootarg needs a revisit > http://monaco.sfbay.sun.com/detail.jsf?cr=6990832 > > Webrev: > https://cr.opensolaris.org/action/browse/caiman/mattman/6990832/ > > Change is pretty simple in that it aligns sparc boot options with X86, > so that on sparc you can specify to prompt for a manifest by providing > the following ok prompt argument : > > aimanifest=prompt > > > Tested on both x86 and sparc with and without the above argument, and AI > prompts for manifest as expected when specified, and does not prompt > when not specified. > > cheers > > Matt > _______________________________________________ > caiman-discuss mailing list > [email protected] > http://mail.opensolaris.org/mailman/listinfo/caiman-discuss _______________________________________________ caiman-discuss mailing list [email protected] http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
