LGTM now, thanks for following up on the use of devprop Matt. Thanks,
Darren. On 24/08/2011 15:01, Matt Keenan wrote: > New webrev ; > https://cr.opensolaris.org/action/browse/caiman/mattman/6990832.2/ > > Includes using devprop instead of prtconf for X86 > > cheers > > Matt > > On 08/24/11 10:54, Matt Keenan wrote: >> Thanks for the review Dave/Darren. >> >> On 08/23/11 15:14, Dave Miner wrote: >>> On 08/23/11 08:26, Darren Kenny wrote: >>>> Hi Matt, >>>> >>>> Generally, looks fine, but one thing that I think might be worth >>>> considering is >>>> whether the 'cut -f2 -d=' would be better as "cut -f2- -d=' to allow >>>> for other >>>> uses of the possible values going forward (e.g. a HTTP url, or similar). >>>> >>>> The difference is that if you have 'a=b=c', yours would return 'b', >>>> while the >>>> other version would return 'b=c' is is probably more like what is >>>> desired. >>>> >> >> Will add this on the Sparc side >> >>>> On another (but related note) maybe this is the time to make the >>>> changes in this >>>> script at least to move from parsing prtconf output to using devprop. >>>> >>>> Dave/Ethan, what do you think? >>>> >>> >>> devprop is much preferred. >>> >> >> I have verified that this works on the x86 side of things, however >> devprop does not function on sparc : >> see bug : 6883221, and doo bug : 11244 >> >> On this basis prtconf will have to continue to be used on sparc. >> >> I'll respin a new webrev with these changes, and email again once tested. >> >> cheers >> >> Matt >> >> >>> Dave >>> >>>> Thanks, >>>> >>>> Darren. >>>> >>>> On 23/08/2011 12:51, Matt Keenan wrote: >>>>> Hi, >>>>> >>>>> Can I get two pairs of eyes for : >>>>> >>>>> 6990832 AI usage of the 'prompt' bootarg needs a revisit >>>>> http://monaco.sfbay.sun.com/detail.jsf?cr=6990832 >>>>> >>>>> Webrev: >>>>> https://cr.opensolaris.org/action/browse/caiman/mattman/6990832/ >>>>> >>>>> Change is pretty simple in that it aligns sparc boot options with X86, >>>>> so that on sparc you can specify to prompt for a manifest by providing >>>>> the following ok prompt argument : >>>>> >>>>> aimanifest=prompt >>>>> >>>>> >>>>> Tested on both x86 and sparc with and without the above argument, >>>>> and AI >>>>> prompts for manifest as expected when specified, and does not prompt >>>>> when not specified. >>>>> >>>>> cheers >>>>> >>>>> Matt >>>>> _______________________________________________ >>>>> caiman-discuss mailing list >>>>> [email protected] >>>>> http://mail.opensolaris.org/mailman/listinfo/caiman-discuss >>> >> >> _______________________________________________ >> caiman-discuss mailing list >> [email protected] >> http://mail.opensolaris.org/mailman/listinfo/caiman-discuss > > _______________________________________________ > caiman-discuss mailing list > [email protected] > http://mail.opensolaris.org/mailman/listinfo/caiman-discuss _______________________________________________ caiman-discuss mailing list [email protected] http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
