William, In general this looks fine. I would like to see an error message anytime the has_error variable is set to True. This does not happen at lines 299 and 303 in create_profile.py and lines 101 and 120 in delete_profile.py.
Thanks, John On Aug 29, 2011, at 11:11 AM, William Schumann wrote: > The remaining fixes are in create_profile.py and delete_profile.py. Multiple > profiles are accepted; exit status 1 if any serious errors are encountered, 0 > otherwise. > > https://cr.opensolaris.org/action/browse/caiman/wmsch/7034620/webrev/ > > Tested success, failure, combined success and failure on single command line. > > Unit tests unaffected. > > Thanks, > William > _______________________________________________ > caiman-discuss mailing list > [email protected] > http://mail.opensolaris.org/mailman/listinfo/caiman-discuss _______________________________________________ caiman-discuss mailing list [email protected] http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
