Sue,
add_profile()'s only errors would be database errors, which are printed
by getResponse().
Thanks for the careful review,
William
On 08/30/11 02:55 PM, Sue Sohn wrote:
On 08/30/11 06:11, William Schumann wrote:
Sue,
Applied all suggestions and re-issued webrev.
Thanks,
William
Hi William,
Can you add an error message at 341? I don't see that one comes from
add_profile.
Other than that, LGTM.
Sue
On 08/29/11 05:16 PM, Sue Sohn wrote:
On 08/29/11 11:11, William Schumann wrote:
The remaining fixes are in create_profile.py and delete_profile.py.
Multiple profiles are accepted;
exit status 1 if any serious errors are encountered, 0 otherwise.
https://cr.opensolaris.org/action/browse/caiman/wmsch/7034620/webrev/
Tested success, failure, combined success and failure on single
command line.
Unit tests unaffected.
Thanks,
William
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
Hi William,
create_profile.py
210 Can you expand this comment? Not clear what "assuming none" means
230 Shouldn't there be a continue after this line? If the file
doesn't exist, we shouldn't try to
open it.
339 should add_errors be set here along with printing an error message?
Sue
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
