Thanks for the review Dave.

On 09/01/11 20:17, David Marker wrote:
Hi Matt,

My eyes kept missing the '#' on 231 of usr/src/lib/install_target/varshared.py 
that prevents /var/shared creation.

usr/src/lib/install_target/varshared.py
line 154: s/moiuntpoint/mountpoint/


Done

Otherwise it looks fine to me.


Thanks

Matt

-Dave

On Sep 1, 2011, at 11:22 AM, Matt Keenan wrote:

Hi,

Can I get some eyes to look at the latest revision of the /var dataset bugs :

  7048015 AI should create a separate /var and shared area
  7049157 Text installer should create a separate /var and shared area
  7049160 GUI installer should create a separate /var and shared area

webrev:
https://cr.opensolaris.org/action/browse/caiman/mattman/7048015.7049157.7049160/

Originally coded to create both a in_be /var dataset and a globally shared 
/var/shared dataset, this has been changed to simply create
/var in_be.

This code has been through code review before, but as we are so close to final 
build, another scan might be no harm.

All the code required for creating /var/shared is still in place just not 
called.

/var/shared work will be undertaken for s11u1 timeframe.
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss


_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss

Reply via email to