Hi Matt,
Mostly nits:
auto_install.py:
line 74 - you haven't made any changes that require
importing varshared
line 99 - how come the list CHECKPOINTS_*BEFORE*_TI
includes TI itself?
line 310: if GUI and Text, you now pause before VarShared.
Should that not also be the case in AI?
gui-install/src/__init__.py
line 47, nit: could you take the opportunity to alphabetically sort
the imports within editing this statement?
line 50 - why move the definition of TARGET_INIT from
gui_install_common to this module?
progress_screen.py
line 49, nit: could you take the opportunity to alphabetically sort
the imports within editing this statement?
ti_install.py
line 244 - nit: can you remove unneeded trailing \ while you are
editing this statement?
varshared.py
line 231 - remove commented code
- Dermot
On 09/01/11 18:22, Matt Keenan wrote:
Hi,
Can I get some eyes to look at the latest revision of the /var dataset
bugs :
7048015 AI should create a separate /var and shared area
7049157 Text installer should create a separate /var and shared area
7049160 GUI installer should create a separate /var and shared area
webrev:
https://cr.opensolaris.org/action/browse/caiman/mattman/7048015.7049157.7049160/
Originally coded to create both a in_be /var dataset and a globally
shared /var/shared dataset, this has been changed to simply create
/var in_be.
This code has been through code review before, but as we are so close
to final build, another scan might be no harm.
All the code required for creating /var/shared is still in place just
not called.
/var/shared work will be undertaken for s11u1 timeframe.
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
