On 13/09/2011 15:09, Jan Damborsky wrote: > Hi Darren, > > > On 09/13/11 15:54, Darren Kenny wrote: >> Hi Jan, >> >> Generally good, the only comment that I have is about the import of main. >> >> I think it would be better to have at the start of the module, and also >> possibly >> just import the sysconfig module, and then call it as sysconfig.main(). >> >> I feel this is more readable. > > Yeah, I would prefer that as well. But moving import of main after > LC_MESSAGES is set is intentional, as it is how 7087759 is addressed.
Ah, ok - if that's the case then I feel a comment to that purpose is warranted. Thanks, Darren. > > Thank you for review, > Jan > >> >> Thanks, >> >> Darren. >> >> >> On 13/09/2011 14:14, Jan Damborsky wrote: >>> Hi, >>> >>> could I please ask Takeshi and one more pair of eyes to review fix for >>> following bugs ? >>> >>> 7087759 snv_174 sysconfig's forcing English display does not work >>> 7086621 sysconfig should check if current terminal is console, before >>> forcing English display >>> 7089508 sample SC profiles configure environment:default instead of >>> environment:init >>> >>> webrev: >>> https://cr.opensolaris.org/action/browse/caiman/dambi/cr-7086621/webrev/ >>> >>> Thank you, >>> Jan >>> >>> testing done: >>> verified that 'sysconfig create-profile' was brought up localized if >>> * run remotely via ssh >>> >>> verified that 'sysconfig create-profile' was brought up in English if >>> * run on physical non-serial (e.g. graphical) console >>> * run on console of non-global zone (accessed via zlogin -C) >>> >>> _______________________________________________ >>> caiman-discuss mailing list >>> [email protected] >>> http://mail.opensolaris.org/mailman/listinfo/caiman-discuss >> _______________________________________________ >> caiman-discuss mailing list >> [email protected] >> http://mail.opensolaris.org/mailman/listinfo/caiman-discuss > _______________________________________________ caiman-discuss mailing list [email protected] http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
