Hi Darren,
On 2011年09月13日 22:54, Darren Kenny wrote:
Hi Jan,
Generally good, the only comment that I have is about the import of main.
Jan would comment as well but the move of the import is
intentional, since the LC_MESSAGES=C setting in sysconfig script
needs to be done before sysconfig module's __init__ is called.
Maybe better to add a comment line to explain this.
Thanks,
Takeshi
I think it would be better to have at the start of the module, and also possibly
just import the sysconfig module, and then call it as sysconfig.main().
I feel this is more readable.
Thanks,
Darren.
On 13/09/2011 14:14, Jan Damborsky wrote:
Hi,
could I please ask Takeshi and one more pair of eyes to review fix for
following bugs ?
7087759 snv_174 sysconfig's forcing English display does not work
7086621 sysconfig should check if current terminal is console, before
forcing English display
7089508 sample SC profiles configure environment:default instead of
environment:init
webrev:
https://cr.opensolaris.org/action/browse/caiman/dambi/cr-7086621/webrev/
Thank you,
Jan
testing done:
verified that 'sysconfig create-profile' was brought up localized if
* run remotely via ssh
verified that 'sysconfig create-profile' was brought up in English if
* run on physical non-serial (e.g. graphical) console
* run on console of non-global zone (accessed via zlogin -C)
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
