Hi Dermot,

In what way does webrev complain? I seem to remember that doing a change like
this would just result in a "file changed" type entry, and you could look at the
'new' link to see the raw png file.

It would be good to at least maybe serve out the workspace using 'hg serv' some
where so people could look at the changeset in mercurial directly...

Hard to review it without seeing anything at all ;)

Thanks,

Darren.

On 13/09/2011 18:27, Dermot McCluskey wrote:
> Hi,
> 
> Can I get a couple of reviewers for this approved
> fix for 175?
> 
> http://monaco.sfbay.sun.com/detail.jsf?cr=7089656
> RFE: need i18n splash screen images integrated into FCS bits
> 
> Details:
> No code changes - just dropping in updated and new
> .png files, plus associated changes to Makefiles
> and manifest file. (Webrev doesn't like .png files - is there
> a way to tag these as binary files in hg?)
> 
> Testing:
> Built LiveCD ISO and started install in all 10 supported
> locales and confirmed that the correct 6 images for
> that locale are displayed during the install.
> 
> - Dermot
> 
> _______________________________________________
> caiman-discuss mailing list
> [email protected]
> http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss

Reply via email to